Skip to content

deps: upgrade npm to 7.0.7 #35908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.0.7 #35908

wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Nov 1, 2020 •
edited by ruyadorno
Loading

7.0.7 (2020-10-30)

BUG FIXES

DEPENDENCIES

7.0.6 (2020-10-27)

BUG FIXES

DEPENDENCIES

7.0.5 (2020-10-23)

  • 77ad86b5e Merge docs deps with main project

7.0.4 (2020-10-23)

DOCUMENTATION

BUG FIXES

TESTS

DEPENDENCIES

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Nov 1, 2020
@targos
Copy link
Member

targos commented Nov 1, 2020

@nodejs/npm

Trott
Trott approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

BridgeAR
BridgeAR approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 2, 2020

I went through and ran the update script on top of this PR to verify that the update was what was expected and things look good. There is a single file missing from this update from some reason, but it is a doc in a dependency

diff --git a/deps/npm/node_modules/uuid/CONTRIBUTING.md b/deps/npm/node_modules/uuid/CONTRIBUTING.md
new file mode 100644
index 0000000000..4a4503d02c
--- /dev/null
+++ b/deps/npm/node_modules/uuid/CONTRIBUTING.md
@@ -0,0 +1,18 @@
+# Contributing
+
+Please feel free to file GitHub Issues or propose Pull Requests. We're always happy to discuss improvements to this library!
+
+## Testing
+
+```shell
+npm test
+```
+
+## Releasing
+
+Releases are supposed to be done from master, version bumping is automated through [`standard-version`](https://github.com/conventional-changelog/standard-version):
+
+```shell
+npm run release -- --dry-run  # verify output manually
+npm run release               # follow the instructions from the output of this command
+```

MylesBorins
MylesBorins approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 2, 2020
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 2, 2020

Can we fast track?

@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34022/

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 2, 2020

Landed in dc05c70

@MylesBorins MylesBorins closed this Nov 2, 2020
MylesBorins pushed a commit that referenced this pull request Nov 2, 2020
@lpinca @MylesBorins
deps: upgrade npm to 7.0.7
dc05c70 
PR-URL: #35908
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@lpinca lpinca deleted the upgrade/npm-to-7.0.7 branch November 3, 2020 06:01
targos pushed a commit that referenced this pull request Nov 3, 2020
@lpinca @targos
deps: upgrade npm to 7.0.7
55adee0 
PR-URL: #35908
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@guybedford guybedford guybedford approved these changes

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@lpinca @targos @MylesBorins @nodejs-github-bot @ruyadorno @guybedford @Trott @BridgeAR